Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662Ab3IFLIO (ORCPT ); Fri, 6 Sep 2013 07:08:14 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:1410 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865Ab3IFLIM (ORCPT ); Fri, 6 Sep 2013 07:08:12 -0400 Message-ID: <5229B779.4000704@huawei.com> Date: Fri, 6 Sep 2013 19:07:37 +0800 From: Xie XiuQi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jonathan Cameron , Dmitry Torokhov , Dmitry Torokhov , Thomas Gleixner , Andres Salomon , Chris Ball , Jon Nettleton , Andrew Morton , Nadia Derbey CC: "linux-kernel@vger.kernel.org" , Li Bin , Tejun Heo Subject: [PATCH 5/5] ipc: remove unnecessary work pending test References: <5229B601.9090109@huawei.com> In-Reply-To: <5229B601.9090109@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.69.18] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 36 Remove unnecessary work pending test before calling schedule_work(). It has been tested in queue_work_on() already. No functional changed. Signed-off-by: Xie XiuQi Cc: Nadia Derbey Cc: Tejun Heo --- ipc/util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ipc/util.c b/ipc/util.c index 4704223..f9105ed 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -67,10 +67,8 @@ static int ipc_memory_callback(struct notifier_block *self, * In order not to keep the lock on the hotplug memory chain * for too long, queue a work item that will, when waken up, * activate the ipcns notification chain. - * No need to keep several ipc work items on the queue. */ - if (!work_pending(&ipc_memory_wq)) - schedule_work(&ipc_memory_wq); + schedule_work(&ipc_memory_wq); break; case MEM_GOING_ONLINE: case MEM_GOING_OFFLINE: -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/