Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484Ab3IFO7Y (ORCPT ); Fri, 6 Sep 2013 10:59:24 -0400 Received: from smtp.citrix.com ([66.165.176.89]:1413 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400Ab3IFO7W (ORCPT ); Fri, 6 Sep 2013 10:59:22 -0400 X-IronPort-AV: E=Sophos;i="4.90,854,1371081600"; d="scan'208";a="51289140" Date: Fri, 6 Sep 2013 15:59:02 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Catalin Marinas CC: Stefano Stabellini , "xen-devel@lists.xensource.com" , "Ian.Campbell@citrix.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "konrad.wilk@oracle.com" Subject: Re: [PATCH v5 11/13] xen: introduce xen_alloc/free_coherent_pages In-Reply-To: <20130906141444.GE1946@arm.com> Message-ID: References: <1377801154-29215-11-git-send-email-stefano.stabellini@eu.citrix.com> <20130905160905.GI11887@arm.com> <20130906141444.GE1946@arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2062 Lines: 47 On Fri, 6 Sep 2013, Catalin Marinas wrote: > On Thu, Sep 05, 2013 at 05:43:33PM +0100, Stefano Stabellini wrote: > > On Thu, 5 Sep 2013, Catalin Marinas wrote: > > > On Thu, Aug 29, 2013 at 07:32:32PM +0100, Stefano Stabellini wrote: > > > > xen_swiotlb_alloc_coherent needs to allocate a coherent buffer for cpu > > > > and devices. On native x86 and ARMv8 is sufficient to call > > > > __get_free_pages in order to get a coherent buffer, while on ARM we need > > > > to call arm_dma_ops.alloc. > > > > > > Don't bet on this for ARMv8. It's not mandated for the architecture, so > > > at some point some SoC will require non-cacheable buffers for coherency. > > > > I see. > > Would it be better if I implemented xen_alloc_coherent_pages on armv8 by > > calling arm64_swiotlb_dma_ops.alloc? > > What does this buffer do exactly? Is it allocated by guests? It is allocated by Dom0 to do DMA to/from a device. It is the buffer that is going to be returned by dma_map_ops.alloc to the caller: On x86: dma_map_ops.alloc -> xen_swiotlb_alloc_coherent -> xen_alloc_coherent_pages -> __get_free_pages On ARM: dma_map_ops.alloc -> xen_swiotlb_alloc_coherent -> xen_alloc_coherent_pages -> arm_dma_ops.alloc On ARM64 dma_map_ops.alloc -> xen_swiotlb_alloc_coherent -> xen_alloc_coherent_pages -> ???? > Currently arm64_swiotlb_dma_ops assume cache-coherent DMA. I have a > patch which introduces new ops for non-coherent DMA but this should > really be orthogonal to swiotlb. You can basically have 4 combinations > of coherent/non-coherent and swiotlb/iommu. Mark Rutland is currently > looking into how best to describe this via DT as it may not even be per > SoC but per bus or device. It seems to me that calling arm64_swiotlb_dma_ops.alloc would ensure that we allocate the right buffer for the right device? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/