Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751560Ab3IFTCt (ORCPT ); Fri, 6 Sep 2013 15:02:49 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:63710 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838Ab3IFTCr (ORCPT ); Fri, 6 Sep 2013 15:02:47 -0400 MIME-Version: 1.0 In-Reply-To: <18764.1378483142@warthog.procyon.org.uk> References: <18764.1378483142@warthog.procyon.org.uk> Date: Fri, 6 Sep 2013 15:02:46 -0400 Message-ID: Subject: Re: [PATCH 0/8] ceph: fscache support & upstream changes From: Milosz Tanski To: Sage Weil Cc: sprabhu@redhat.com, ceph-devel , "Yan, Zheng" , Hongyi Jia , "linux-cachefs@redhat.com" , "linux-fsdevel@vger.kernel.org" , linux-kernel@vger.kernel.org, David Howells Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1884 Lines: 47 Sage, I've taken David's latest changes and per his request merged his 'fscache-fixes-for-ceph' tag then applied my changes on top of that. In addition to the pervious changes I also added a fix for the warnings the linux-next build bot found. I've given the results a quick test to make sure it builds, boots and runs okay. The code is located in my repository: https://adfin@bitbucket.org/adfin/linux-fs.git in the wip-fscache-v2 branch I hope that this is the final go for now and thanks for everyone's patience. - Milosz On Fri, Sep 6, 2013 at 11:59 AM, David Howells wrote: > Milosz Tanski wrote: > >> After running this for a day on some loaded machines I ran into what >> looks like an old issue with the new code. I remember you saw an issue >> that manifested it self in a similar way a while back. >> >> [13837253.462779] FS-Cache: Assertion failed >> [13837253.462782] 3 == 5 is false >> [13837253.462807] ------------[ cut here ]------------ >> [13837253.462811] kernel BUG at fs/fscache/operation.c:414! > > Bah. > > I forgot to call fscache_op_complete(). Patch updated and repushed. > > Btw, I've reordered the patches to put the CIFS patch last. Can you merge the > patches prior to the CIFS commit from my branch rather than cherry picking > them so that if they go via two different routes, GIT will handle the merge > correctly? I've stuck a tag on it (fscache-fixes-for-ceph) to make that > easier for you. > > I've also asked another RH engineer to try doing some basic testing on the > CIFS stuff - which may validate the fscache_readpages_cancel patch. > > David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/