Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128Ab3IFX5l (ORCPT ); Fri, 6 Sep 2013 19:57:41 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]:52876 "EHLO mail-vc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727Ab3IFX5j (ORCPT ); Fri, 6 Sep 2013 19:57:39 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130906202022.GA353@x4> Date: Fri, 6 Sep 2013 16:57:38 -0700 X-Google-Sender-Auth: e-2bkYspLzUEBLFYwZQAY205dG4 Message-ID: Subject: Re: [GIT] HID for 3.12 merge window From: Linus Torvalds To: David Herrmann Cc: Markus Trippelsdorf , Jiri Kosina , linux-kernel , "open list:HID CORE LAYER" , Dmitry Torokhov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 36 On Fri, Sep 6, 2013 at 2:50 PM, David Herrmann wrote: > Hi > > On Fri, Sep 6, 2013 at 10:20 PM, Markus Trippelsdorf >> >> commit 61e00655e9cb82e034eb72b95a51072e718d14a7 >> Author: David Herrmann >> Date: Mon Aug 26 19:14:46 2013 +0200 >> >> Input: introduce BTN/ABS bits for drums and guitars >> >> The commit above breaks my Logitech mouse. The mouse cursor just sits in >> the middle of the screen and doesn't react to movements. dmesg is >> normal, but Xorg.0.log says: > > Ok, the issue is the kernel assumes ABS_MAX to be a power-of-2 minus 1 > (used as mask). That wasn't really obvious to me. Attached is a patch > which should fix that. Could you apply it on top of linus/master and > give it a try? Gah. I just wasted too much time bisecting down my logitech wireless keyboard not working to within a few commits of this, and decided to just try your patch. And yes, it makes my keyboard work. Dmitry, should I just apply the patch, or should we revert and use other bits? Please, this needs to be resolved, I stopped merging when I noticed this problem.. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/