Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751217Ab3IGRbH (ORCPT ); Sat, 7 Sep 2013 13:31:07 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:53482 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821Ab3IGRbF (ORCPT ); Sat, 7 Sep 2013 13:31:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130906202022.GA353@x4> <506b9d43-f734-40f9-b137-0749a496fd6d@email.android.com> <20130907032240.GA1256@core.coreip.homeip.net> Date: Sat, 7 Sep 2013 19:31:02 +0200 Message-ID: Subject: Re: [GIT] HID for 3.12 merge window From: David Herrmann To: Linus Torvalds Cc: Dmitry Torokhov , Markus Trippelsdorf , Jiri Kosina , linux-kernel , "open list:HID CORE LAYER" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 27 Hi Linus On Sat, Sep 7, 2013 at 6:52 PM, Linus Torvalds wrote: > On Sat, Sep 7, 2013 at 12:31 AM, David Herrmann wrote: >> >> The bug only occurs for multi-touch devices (their ABS_* bits are >>>0x1f), that's why I didn't see it happening during my tests.. > > It definitely affects keyboards too. That's how I noticed it. That is > with the logitech "universal" receiver, though, so maybe that counts > as a potential multi-touch device.. I have been quite wrong with that statement, yepp. xorg-evdev fetches the whole device-information. So if a keyboard provides an affected ABS_* bit, it'll break, too. My ancient hardware didn't use any of the higher ABS bits, though. I'm sorry for the troubles caused. ABS_MAX must be at most 0x3f. So please, go ahead and revert the 3 mentioned patches. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/