Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752990Ab3IHO0I (ORCPT ); Sun, 8 Sep 2013 10:26:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20692 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818Ab3IHO0G convert rfc822-to-8bit (ORCPT ); Sun, 8 Sep 2013 10:26:06 -0400 Date: Sun, 8 Sep 2013 17:26:02 +0300 From: Gleb Natapov To: Xiao Guangrong Cc: Xiao Guangrong , avi.kivity@gmail.com, mtosatti@redhat.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 01/15] KVM: MMU: fix the count of spte number Message-ID: <20130908142602.GL17294@redhat.com> References: <1378376958-27252-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <1378376958-27252-2-git-send-email-xiaoguangrong@linux.vnet.ibm.com> <20130908121917.GH17294@redhat.com> <20130908140149.GA6468@redhat.com> <6A5E49EE-3729-4825-AF31-CF03DDD92E64@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=cp1255 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <6A5E49EE-3729-4825-AF31-CF03DDD92E64@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 38 On Sun, Sep 08, 2013 at 10:24:05PM +0800, Xiao Guangrong wrote: > > On Sep 8, 2013, at 10:01 PM, Gleb Natapov wrote: > > > On Sun, Sep 08, 2013 at 09:55:04PM +0800, Xiao Guangrong wrote: > >> > >> On Sep 8, 2013, at 8:19 PM, Gleb Natapov wrote: > >> > >>> On Thu, Sep 05, 2013 at 06:29:04PM +0800, Xiao Guangrong wrote: > >>>> If the desc is the last one and it is full, its sptes is not counted > >>>> > >>> Hmm, if desc is not full but it is not the last one all sptes after the > >>> desc are not counted too. > >> > >> But the desc must be the last one if it's not full since we always add > >> new entry or delete entry from the last desc. > >> > > Why do we alway delete entries from last desc? We delete them from the > > desc we found them in. Current code does not try to move entries between > > descs, only inside a desc. > > Oh, yes. Sorry, my memory is wrong? :( > > So, currently there has some gaps in desc and it wastes memory. Can not fix > them with simple change and i think it is not worthy to fix them separately since > after my new algorithm, these should all be fixed? so how about just drop this > fix? > Yes, if we are going to change algorithm anyway no need to spend time fixing what we have now. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/