Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710Ab3IHPWr (ORCPT ); Sun, 8 Sep 2013 11:22:47 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:45906 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753529Ab3IHPWm (ORCPT ); Sun, 8 Sep 2013 11:22:42 -0400 From: Jiang Liu To: Andrew Morton , Shaohua Li , Wang YanQing Cc: liuj97@gmail.com, Jiang Liu , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Paul Gortmaker , liguang , linux-kernel@vger.kernel.org Subject: [PATCH v1 2/3] SMP: simpilify function generic_smp_call_function_single_interrupt() Date: Sun, 8 Sep 2013 23:22:24 +0800 Message-Id: <1378653745-8343-2-git-send-email-liuj97@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1378653745-8343-1-git-send-email-liuj97@gmail.com> References: <1378653745-8343-1-git-send-email-liuj97@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1819 Lines: 61 From: Jiang Liu Now the call_single_data data structure is always locked by invoking csd_lock() before inserting it into corresponding call_single_queue list, so no need to save and check csd->flags in function generic_smp_call_function_single_interrupt(). Signed-off-by: Jiang Liu Cc: Jiang Liu Cc: Andrew Morton Cc: Wang YanQing Cc: Shaohua Li Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Steven Rostedt Cc: Paul Gortmaker Cc: liguang Cc: linux-kernel@vger.kernel.org --- kernel/smp.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/kernel/smp.c b/kernel/smp.c index a034712..baa2a65 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -181,25 +181,11 @@ void generic_smp_call_function_single_interrupt(void) while (!list_empty(&list)) { struct call_single_data *csd; - unsigned int csd_flags; csd = list_entry(list.next, struct call_single_data, list); list_del(&csd->list); - - /* - * 'csd' can be invalid after this call if flags == 0 - * (when called through generic_exec_single()), - * so save them away before making the call: - */ - csd_flags = csd->flags; - csd->func(csd->info); - - /* - * Unlocked CSDs are valid through generic_exec_single(): - */ - if (csd_flags & CSD_FLAG_LOCK) - csd_unlock(csd); + csd_unlock(csd); } } -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/