Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758535Ab3IHRiU (ORCPT ); Sun, 8 Sep 2013 13:38:20 -0400 Received: from mail-bn1lp0150.outbound.protection.outlook.com ([207.46.163.150]:33586 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757459Ab3IHRiS (ORCPT ); Sun, 8 Sep 2013 13:38:18 -0400 From: Matthew Garrett To: James Bottomley CC: Kees Cook , Greg KH , "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" , "hpa@zytor.com" Subject: Re: [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions Thread-Topic: [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions Thread-Index: AQHOqQBlTgRtcELUZ0K5HxHj5bQ8FZm7apqAgAC2VJ6AAAFzgA== Date: Sun, 8 Sep 2013 17:38:13 +0000 Message-ID: <1378661893.2300.28.camel@x230> References: <1378252218-18798-1-git-send-email-matthew.garrett@nebula.com> <1378252218-18798-9-git-send-email-matthew.garrett@nebula.com> <20130908064027.GA3587@kroah.com> <1378622648.2300.4.camel@x230> <20130908072408.GA5092@kroah.com> <1378660284.2429.11.camel@dabdike.int.hansenpartnership.com> <1378660541.2300.19.camel@x230> <1378660975.2429.14.camel@dabdike.int.hansenpartnership.com> <1378661252.2300.26.camel@x230> <1378661576.2429.16.camel@dabdike.int.hansenpartnership.com> In-Reply-To: <1378661576.2429.16.camel@dabdike.int.hansenpartnership.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:470:1f07:1371:740c:5537:5f2f:efde] x-forefront-prvs: 09634B1196 x-forefront-antispam-report: SFV:NSPM;SFS:(24454002)(377424004)(51704005)(189002)(199002)(50986001)(81686001)(4396001)(49866001)(47976001)(47736001)(74366001)(81342001)(76796001)(79102001)(81542001)(76786001)(59766001)(83072001)(77982001)(51856001)(19580395003)(33646001)(65816001)(33716001)(80976001)(83322001)(19580405001)(74502001)(47446002)(80022001)(56816003)(77096001)(31966008)(74662001)(74876001)(76482001)(63696002)(69226001)(54356001)(56776001)(46102001)(54316002)(74706001)(81816001)(53806001)(3826001);DIR:OUT;SFP:;SCL:1;SRVR:BY2PR05MB224;H:BY2PR05MB222.namprd05.prod.outlook.com;CLIP:2001:470:1f07:1371:740c:5537:5f2f:efde;RD:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" Content-ID: <3CA20E5EE26CAF42914DA6338E9FE0F0@namprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r88HcPqR015674 Content-Length: 1321 Lines: 24 On Sun, 2013-09-08 at 10:32 -0700, James Bottomley wrote: > On Sun, 2013-09-08 at 17:27 +0000, Matthew Garrett wrote: > > > It's an argument that CAP_SYS_BOOT is too powerful yes, but if you > > > recall, I said I keep that one. In the rather lame analogy, what I do > > > by giving away CAP_SYS_MODULE and enforcing module signing while keeping > > > CAP_SYS_BOOT is allow people into my conservatory to play with the > > > plants but not into my house to steal the silver ... saying CAP_SYS_BOOT > > > is too powerful doesn't affect that use case because I haven't given > > > away CAP_SYS_BOOT. > > > > Ok, sorry, I had your meaning inverted. Yes, permitting the loading of > > signed modules while preventing the use of kexec is a completely > > reasonable configuration - so reasonable that it's what this patch > > causes the kernel to do automatically. > > Well, no, it doesn't because with this patch, *I* can't use kexec ... > you've just locked me out of my own house. Hm. Ok, that's a more compelling argument than Greg's. Let me think about whether there's a convenient way of supporting this. -- Matthew Garrett ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?