Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751431Ab3IICI0 (ORCPT ); Sun, 8 Sep 2013 22:08:26 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:24266 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240Ab3IICIZ (ORCPT ); Sun, 8 Sep 2013 22:08:25 -0400 Message-ID: <522D2D82.2070604@huawei.com> Date: Mon, 9 Sep 2013 10:08:02 +0800 From: Xie XiuQi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jiang Liu , Jiang Liu CC: Andrew Morton , Shaohua Li , Wang YanQing , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Paul Gortmaker , liguang , Subject: Re: [PATCH v1 2/3] SMP: simpilify function generic_smp_call_function_single_interrupt() References: <1378653745-8343-1-git-send-email-liuj97@gmail.com> <1378653745-8343-2-git-send-email-liuj97@gmail.com> In-Reply-To: <1378653745-8343-2-git-send-email-liuj97@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.69.18] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2134 Lines: 66 On 2013/9/8 23:22, Jiang Liu wrote: > From: Jiang Liu > > Now the call_single_data data structure is always locked by invoking > csd_lock() before inserting it into corresponding call_single_queue > list, so no need to save and check csd->flags in function > generic_smp_call_function_single_interrupt(). > > Signed-off-by: Jiang Liu > Cc: Jiang Liu > Cc: Andrew Morton > Cc: Wang YanQing > Cc: Shaohua Li > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Steven Rostedt > Cc: Paul Gortmaker > Cc: liguang > Cc: linux-kernel@vger.kernel.org Hi, I've sent a same patch before and it has been applied by Ingo. See http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=46591962cb5bfd2bfb0baf42497119c816503598 > --- > kernel/smp.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/kernel/smp.c b/kernel/smp.c > index a034712..baa2a65 100644 > --- a/kernel/smp.c > +++ b/kernel/smp.c > @@ -181,25 +181,11 @@ void generic_smp_call_function_single_interrupt(void) > > while (!list_empty(&list)) { > struct call_single_data *csd; > - unsigned int csd_flags; > > csd = list_entry(list.next, struct call_single_data, list); > list_del(&csd->list); > - > - /* > - * 'csd' can be invalid after this call if flags == 0 > - * (when called through generic_exec_single()), > - * so save them away before making the call: > - */ > - csd_flags = csd->flags; > - > csd->func(csd->info); > - > - /* > - * Unlocked CSDs are valid through generic_exec_single(): > - */ > - if (csd_flags & CSD_FLAG_LOCK) > - csd_unlock(csd); > + csd_unlock(csd); > } > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/