Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005Ab3IIKSI (ORCPT ); Mon, 9 Sep 2013 06:18:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195Ab3IIKSF (ORCPT ); Mon, 9 Sep 2013 06:18:05 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <18764.1378483142@warthog.procyon.org.uk> To: Milosz Tanski Cc: dhowells@redhat.com, sprabhu@redhat.com, ceph-devel , "Yan, Zheng" , Hongyi Jia , "linux-cachefs@redhat.com" , "linux-fsdevel@vger.kernel.org" , linux-kernel@vger.kernel.org, Sage Weil Subject: Re: [PATCH 0/8] ceph: fscache support & upstream changes Date: Mon, 09 Sep 2013 11:17:58 +0100 Message-ID: <13594.1378721878@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 17 Milosz Tanski wrote: > - (1 << FSCACHE_OP_WAITING); > + (1 << FSCACHE_OP_WAITING) | > + (1 << FSCACHE_OP_UNUSE_COOKIE); Yeah... That'll do it. We could just decrement n_active directly after calling into the backend - after all, we cannot reduce n_active to 0 here because the netfs cannot be calling fscache_relinquish_cookie() whilst also calling this function - but this will do too. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/