Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845Ab3IILpA (ORCPT ); Mon, 9 Sep 2013 07:45:00 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:41065 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005Ab3IILo6 (ORCPT ); Mon, 9 Sep 2013 07:44:58 -0400 Message-ID: <1378727093.13401.3.camel@ThinkPad-X230.localdomain> Subject: Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8 From: Igor Gnatenko To: Aaron Lu Cc: ACPI Devel Mailing List , "Rafael J. Wysocki" , Matthew Garrett , Seth Forshee , "Lee, Chun-Yi" , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Len Brown , Yves-Alexis Perez , Felipe Contreras , Lee Chun-Yi , Henrique de Moraes Holschuh Date: Mon, 09 Sep 2013 15:44:53 +0400 In-Reply-To: <522D89EC.6050103@intel.com> References: <522D88C3.7000808@intel.com> <522D89EC.6050103@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.9.91 (3.9.91-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 41 On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index f466980..75fba17 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1650,7 +1650,7 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) > if (INTEL_INFO(dev)->num_pipes) { > /* Must be done after probing outputs */ > intel_opregion_init(dev); > - acpi_video_register(); > + __acpi_video_register(i915_take_over_backlight); > } > > if (IS_GEN5(dev)) I can't compile: DEBUG: drivers/gpu/drm/i915/i915_dma.c: In function 'i915_driver_load': DEBUG: drivers/gpu/drm/i915/i915_dma.c:1661:3: error: implicit declaration of function '__acpi_video_register' [-Werror=implicit-function-declaration] DEBUG: __acpi_video_register(i915_take_over_backlight); DEBUG: ^ DEBUG: cc1: some warnings being treated as errors DEBUG: make[4]: *** [drivers/gpu/drm/i915/i915_dma.o] Error 1 DEBUG: make[3]: *** [drivers/gpu/drm/i915] Error 2 DEBUG: make[2]: *** [drivers/gpu/drm] Error 2 DEBUG: make[1]: *** [drivers/gpu] Error 2 DEBUG: make: *** [drivers] Error 2 -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.11.0-3.fc20.x86_64 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/