Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="ISO-8859-1"
MIME-Version: 1.0
Date: Fri, 18 Oct 2002 14:49:53 UT
From: "Jeffrey Lim" <kernel-list@jfsworld.fastmail.fm>
To: "David S. Miller" <davem@redhat.com>, genlogic@inrete.it
Cc: linux-kernel@vger.kernel.org
Subject: Re: unhappy with current.h
Message-Id: <20021018144951.337862FD51@server4.fastmail.fm>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1559
Lines: 39


On Mon, 14 Oct 2002 12:52:34 -0700 (PDT), "David S. Miller"
<davem@redhat.com> said:
>
>        From: Daniele Lugli <genlogic@inrete.it>
>        Date: Mon, 14 Oct 2002 21:46:08 +0200
>    
>        Moral of the story: in my opinion kernel developers should reduce to a
>        minimum the use of #define, and preferably use words in uppercase
>        and/or with underscores, in any case not commonly used words.
> 
> Or maybe you should change your datastructure to not have member names
> the conflict with 7 year old well defined global symbols in the Linux
> kernel?
>

I guess tradition may have been well established. Is there an faq for
this somewhere (for these "well defined global symbols", that is) that we
could perhaps refer to?

I do believe he has a point though. It would be good to watch the
#defines in the future, so as to make it easier for aspiring coders.

-jf
 
#!/bin/signoff
# ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~
echo The reasonable man adapts himself to the world; the unreasonable one
echo persists in trying to adapt the world to himself. Therefore, all
echo progress depends on the unreasonable.
echo                                              ? George Bernard Shaw
# ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~
 
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/