Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359Ab3IIObq (ORCPT ); Mon, 9 Sep 2013 10:31:46 -0400 Received: from mail-ve0-f173.google.com ([209.85.128.173]:44936 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237Ab3IIObp (ORCPT ); Mon, 9 Sep 2013 10:31:45 -0400 MIME-Version: 1.0 In-Reply-To: <20130908084606.GA3938@cantor.Home> References: <20130908084606.GA3938@cantor.Home> Date: Mon, 9 Sep 2013 07:31:44 -0700 X-Google-Sender-Auth: 0Wnl0yJCCucjTPa7qzyjtQ6wzWg Message-ID: Subject: Re: suspicious RCU usage with unlazy_walk() From: Linus Torvalds To: Jerry Snitselaar Cc: Waiman Long , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 23 On Sun, Sep 8, 2013 at 1:46 AM, Jerry Snitselaar wrote: > Running 3.11.0-07547-g44598f9 I hit the following last night. I have > not had it reproduce since then. Should there be some lock cleanup in > the error path prior to the dput() call like unlock_rcu_walk()? Heh. I should have read more email yesterday, but I was too busy looking at the dentry code, so I didn't get to some of my mailbox until now. Happily, the reason I was too busy was that I had noticed that my d_rcu_to_refcount() changes were bad, and spent that time cleaning it up and fixing this bug. So this should be fixed in the current tree (current top of tree, commit e5c832d55588 in particular). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/