Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755393Ab3IIQjG (ORCPT ); Mon, 9 Sep 2013 12:39:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58026 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753604Ab3IIQjE (ORCPT ); Mon, 9 Sep 2013 12:39:04 -0400 Date: Mon, 9 Sep 2013 09:39:02 -0700 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Guenter Roeck , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Peng Tao , Peng Tao Subject: Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA Message-ID: <20130909163902.GA28685@kroah.com> References: <1378688580-11935-1-git-send-email-linux@roeck-us.net> <20130909015945.GA4029@kroah.com> <20130909134012.GA24738@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130909134012.GA24738@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 20 On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote: > On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote: > > Can't we just export the functions for those arches? Surely lutre > > isn't the first/only driver that needs this? > > Lustre is. These are core mm helpers, and lustre uses them to > reimplement another core VM function. It then uses it to access > userspace environment variable. > > In short all this code should be nuked, and no new symbols should be > exported. Ugh, you are right, the lustre code needs to be fixed here. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/