Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755443Ab3IIUGP (ORCPT ); Mon, 9 Sep 2013 16:06:15 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:40970 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255Ab3IIUGO (ORCPT ); Mon, 9 Sep 2013 16:06:14 -0400 Date: Mon, 9 Sep 2013 13:06:10 -0700 From: Guenter Roeck To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , "David S. Miller" , Christoph Hellwig , "linux-kernel@vger.kernel.org" , driverdevel , Peng Tao , Peng Tao Subject: Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA Message-ID: <20130909200610.GA28416@roeck-us.net> References: <1378688580-11935-1-git-send-email-linux@roeck-us.net> <20130909015945.GA4029@kroah.com> <20130909134012.GA24738@infradead.org> <20130909163902.GA28685@kroah.com> <20130909170819.GA22764@roeck-us.net> <20130909172232.GA10029@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2622 Lines: 59 On Mon, Sep 09, 2013 at 09:11:25PM +0200, Geert Uytterhoeven wrote: > On Mon, Sep 9, 2013 at 7:22 PM, Greg Kroah-Hartman > wrote: > > On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote: > >> On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote: > >> > On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote: > >> > > On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote: > >> > > > Can't we just export the functions for those arches? Surely lutre > >> > > > isn't the first/only driver that needs this? > >> > > > >> > > Lustre is. These are core mm helpers, and lustre uses them to > >> > > reimplement another core VM function. It then uses it to access > >> > > userspace environment variable. > >> > > > >> > > In short all this code should be nuked, and no new symbols should be > >> > > exported. > >> > > >> > Ugh, you are right, the lustre code needs to be fixed here. > >> > > >> Given that, should I send another patch marking it as BROKEN again ? > > > > Well, on those arches it's "broken", so I'll dig up your original patch > > on this thread. It's just "normal" for staging drivers to duplicate > > core code, it needs to be fixed up before it can be merged into the > > kernel tree, so no need to do anything special. > > It's not only broken on MIPS, SH, and XTENSA, but also on at least parisc > and m68k[*]. > > It's no longer broken on sparc64, as the missing export already got > into mainline. > In light of the above, perhaps that should be reverted? > Agreed. > [*] Why does m68k allmodconfig still succeed on kissb??? > It does fail for me, as m68k's copy_from_user_page() calls > flush_icache_user_range(), which is not exported. > I don't see a build failure in m68k:allmodconfig either. flush_icache_user_range() is called from copy_to_user_page(), not from copy_from_user_page(). copy_from_user_page() calls flush_cache_page() which calls __flush_cache_030(). The first is inline, the second is assembler, so I would expect it to work. Which doesn't answer the question why it fails for you. powerpc and frm export flush_icache_user_range(). Wonder if that is really necessary or points to other abuses. On parisc I currently only test defconfig. I'll check if allmodconfig passes in 3.10 and/or 3.11; if yes I'll add it to my test suite. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/