Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755707Ab3IIUOp (ORCPT ); Mon, 9 Sep 2013 16:14:45 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:55184 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753837Ab3IIUOo (ORCPT ); Mon, 9 Sep 2013 16:14:44 -0400 Message-ID: <522E3A47.3000307@kernel.org> Date: Mon, 09 Sep 2013 22:14:47 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130806 Thunderbird/17.0.8 MIME-Version: 1.0 To: michael.hennerich@analog.com CC: Tejun Heo , Xie XiuQi , Jonathan Cameron , Dmitry Torokhov , Dmitry Torokhov , Thomas Gleixner , Andres Salomon , Chris Ball , Jon Nettleton , Andrew Morton , Nadia Derbey , "linux-kernel@vger.kernel.org" , Li Bin , Lars-Peter Clausen Subject: Re: [PATCH 1/5] iio: adc: remove unnecessary work pending test References: <5229B601.9090109@huawei.com> <5229B64A.1030304@huawei.com> <20130906152028.GA22763@mtj.dyndns.org> <522B903C.7040604@kernel.org> <522DE7F4.1050202@analog.com> In-Reply-To: <522DE7F4.1050202@analog.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2281 Lines: 65 On 09/09/13 16:23, Michael Hennerich wrote: > On 09/07/2013 10:44 PM, Jonathan Cameron wrote: >> ccing Michael Hennerich and Lars-Peter Clausen, > > Looks good to me! > > /Acked-by/: /Michael Hennerich/ Applied to the togreg branch of iio.git. Thanks > >> >> On 09/06/13 16:20, Tejun Heo wrote: >>> On Fri, Sep 06, 2013 at 07:02:34PM +0800, Xie XiuQi wrote: >>>> Remove unnecessary work pending test before calling schedule_work(). >>>> It has been tested in queue_work_on() already. No functional changed. >>>> >>>> Signed-off-by: Xie XiuQi >>>> Cc: Tejun Heo >>> Reviewed-by: Tejun Heo >>> >>> One nit below tho. >>> >>>> - if (iio_buffer_enabled(indio_dev)) { >>>> - if (!work_pending(&st->poll_work)) >>>> - schedule_work(&st->poll_work); >>>> - } else { >>>> + if (iio_buffer_enabled(indio_dev)) >>>> + schedule_work(&st->poll_work); >>>> + else { >>>> st->done = true; >>>> wake_up_interruptible(&st->wq_data_avail); >>>> } >>> Please don't drop the parentheses. The convention is to have either >>> both or none on if/else. >> I'll fix this up on applying if everyone is happy (can't see why the >> won't be, but best to check!) Michael is clearly given as the author of driver >> so should probably have been in the cc list. Whilst I might apply this directly >> as maintainer I much prefer if I get an ack from the driver author as if nothing >> else it gives me a warm fuzzy feeling ;) >> >> Also patch title should mention that a) this is a staging driver, b) which adc driver it >> applies to. I'll fix that up as well on applying it. >> >> Thanks for the patch though, it would probably never have been noticed otherwise! >> >>> Thanks. >>> > > > -- > Greetings, > Michael > > -- > Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen > Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; > Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, > Margaret Seif > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/