Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756398Ab3IIXBy (ORCPT ); Mon, 9 Sep 2013 19:01:54 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:39817 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756365Ab3IIXBv (ORCPT ); Mon, 9 Sep 2013 19:01:51 -0400 From: "Rafael J. Wysocki" To: Guennadi Liakhovetski Cc: Viresh Kumar , Greg KH , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, cpufreq@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm Subject: Re: "cpufreq: fix serialization issues with freq change notifiers" breaks cpufreq too Date: Tue, 10 Sep 2013 01:12:49 +0200 Message-ID: <2339390.oQAxMuU2Y5@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.11.0+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <1883706.eFcILAzoo8@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2558 Lines: 71 On Monday, September 09, 2013 11:42:41 PM Guennadi Liakhovetski wrote: > Hi Rafael > > On Mon, 9 Sep 2013, Rafael J. Wysocki wrote: > > > Hi, > > > > On Monday, September 09, 2013 05:11:10 PM Guennadi Liakhovetski wrote: > > > Sorry guys, I'm trying my best to stop this patch from propagating to > > > stable and to get it fixed asap, so, the CC list might be a bit excessive. > > > Also trying to fix the originally spare cc list, which makes it impossible > > > for me to reply to the original thread, instead have to start a new one. > > > > I'm not sure what you're talking about. What exactly was wrong with the > > original CC list in particular? > > I think you advised once to cc cpufreq related mails to linux-pm too at > least. Yes, I did. > I haven't found this patch in my pm archive, have I missed it there? Quite frankly, I don't remember if it was there. ISTR having it it patchwork, which would mean that it was there, but well. > > > Commit > > > > > > commit dceff5ce18801dddc220d6238628619c93bc3cb6 > > > Author: Viresh Kumar > > > Date: Sun Sep 1 22:19:37 2013 +0530 > > > > > > cpufreq: fix serialization issues with freq change notifiers > > > > > > breaks .transition_ongoing counting. > > > > Do you know how exactly it breaks that? If so, care to share that knowledge? > > No, I don't. I only know that in __cpufreq_driver_target() the check for > > if (policy->transition_ongoing) { > write_unlock_irqrestore(&cpufreq_driver_lock, flags); > return -EBUSY; > } > > is failing with this patch and cpufreq-cpu0. OK, we need to figure out that, then. > > > This leads to cpufreq-cpu0 not working any more. In particular switching the > > > governor from performance to powersave directly after boot doesn't result in > > > a frequency switch any more. Reverting this patch fixes the problem again. > > > > However, this is a regression fix, so I'd prefer to fix the problem on top of > > it instead of reverting this commit entirely. > > If I understood correctly, this patch fixed some warnings, that, however, > didn't disrupt functionality, is this right? Whereas the patch really > seems to break working set ups. It fixed warnings that indicated problems and those problems should rather be avoided. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/