Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756060Ab3IIXKn (ORCPT ); Mon, 9 Sep 2013 19:10:43 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:56970 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755841Ab3IIXKl (ORCPT ); Mon, 9 Sep 2013 19:10:41 -0400 Message-ID: <522E556D.1070108@codeaurora.org> Date: Mon, 09 Sep 2013 16:10:37 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Rohit Vaswani CC: David Brown , Daniel Walker , Bryan Huntsman , Russell King , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: msm: Create a common board-dt and config ARCH_MSM_DT References: <1378767719-27688-1-git-send-email-rvaswani@codeaurora.org> <1378767719-27688-2-git-send-email-rvaswani@codeaurora.org> In-Reply-To: <1378767719-27688-2-git-send-email-rvaswani@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1753 Lines: 57 On 09/09/13 16:01, Rohit Vaswani wrote: > diff --git a/arch/arm/mach-msm/board-dt.c b/arch/arm/mach-msm/board-dt.c > new file mode 100644 > index 0000000..c140c53 > --- /dev/null > +++ b/arch/arm/mach-msm/board-dt.c > @@ -0,0 +1,32 @@ > +/* Copyright (c) 2010-2012, The Linux Foundation. All rights reserved. Bump to 2013? > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > +#include > + > +#include > +#include > + > +#include "common.h" > + > +static const char *msm_dt_match[] __initdata = { static const char * const msm_dt_match[] __initconst is better. > + "qcom,msm8660-fluid", > + "qcom,msm8660-surf", > + "qcom,msm8960-cdp", > + NULL > +}; > + > +DT_MACHINE_START(MSM_DT, "Qualcomm MSM (Flattened Device Tree)") > + .smp = smp_ops(msm_smp_ops), > + .dt_compat = msm_dt_match, > +MACHINE_END Otherwise feel free to add my reviewed-by. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/