Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423Ab3IJFXt (ORCPT ); Tue, 10 Sep 2013 01:23:49 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:53068 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752957Ab3IJFXs (ORCPT ); Tue, 10 Sep 2013 01:23:48 -0400 Message-ID: <1378790623.2160.2.camel@ThinkPad-X230.localdomain> Subject: Re: [PATCH 1/2] ACPI / video: seperate backlight control and event interface From: Igor Gnatenko To: Aaron Lu Cc: ACPI Devel Mailing List , "Rafael J. Wysocki" , Matthew Garrett , Seth Forshee , "Lee, Chun-Yi" , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Len Brown , Yves-Alexis Perez , Felipe Contreras , Lee Chun-Yi , Henrique de Moraes Holschuh Date: Tue, 10 Sep 2013 09:23:43 +0400 In-Reply-To: <522D8991.5070707@intel.com> References: <522D88C3.7000808@intel.com> <522D8991.5070707@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.9.91 (3.9.91-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1783 Lines: 41 On Mon, 2013-09-09 at 16:40 +0800, Aaron Lu wrote: > The backlight control and event delivery functionality provided by ACPI > video module is mixed together and registered all during video device > enumeration time. As a result, the two functionality are also removed > together on module unload time or by the acpi_video_unregister function. > The two functionalities are actually independent and one may be useful > while the other one may be broken, so it is desirable to seperate the > two functionalities such that it is clear and easy to disable one > functionality without affecting the other one. This patch does the > seperation and as a result, a new video_bus_head list is introduced to > store all registered video bus structure and a new function > acpi_video_unregister_backlight is introduced to unregister backlight > interfaces for all video devices belonging to stored video buses. > > Currently, there is no need to unregister ACPI video's event delivery > functionality alone so the function acpi_video_remove_notify_handler is > not introduced, it can be easily added when needed. > > Signed-off-by: Aaron Lu Tested-by: Igor Gnatenko > --- > drivers/acpi/video.c | 451 ++++++++++++++++++++++++++++++--------------------- > include/acpi/video.h | 2 + > 2 files changed, 264 insertions(+), 189 deletions(-) -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.11.0-3.fc20.x86_64 -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.11.0-1.fc20.x86_64 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/