Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468Ab3IJJcv (ORCPT ); Tue, 10 Sep 2013 05:32:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57081 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398Ab3IJJct (ORCPT ); Tue, 10 Sep 2013 05:32:49 -0400 From: Mel Gorman To: Peter Zijlstra , Rik van Riel Cc: Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML , Mel Gorman Subject: [PATCH 15/50] sched: numa: Correct adjustment of numa_scan_period Date: Tue, 10 Sep 2013 10:31:55 +0100 Message-Id: <1378805550-29949-16-git-send-email-mgorman@suse.de> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1378805550-29949-1-git-send-email-mgorman@suse.de> References: <1378805550-29949-1-git-send-email-mgorman@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 31 numa_scan_period is in milliseconds, not jiffies. Properly placed pages slow the scanning rate but adding 10 jiffies to numa_scan_period means that the rate scanning slows depends on HZ which is confusing. Get rid of the jiffies_to_msec conversion and treat it as ms. Signed-off-by: Mel Gorman --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 23fd1f3..29ba117 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -914,7 +914,7 @@ void task_numa_fault(int node, int pages, bool migrated) p->numa_scan_period_max = task_scan_max(p); p->numa_scan_period = min(p->numa_scan_period_max, - p->numa_scan_period + jiffies_to_msecs(10)); + p->numa_scan_period + 10); } task_numa_placement(p); -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/