Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197Ab3IJJmb (ORCPT ); Tue, 10 Sep 2013 05:42:31 -0400 Received: from mga09.intel.com ([134.134.136.24]:13559 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011Ab3IJJm1 (ORCPT ); Tue, 10 Sep 2013 05:42:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,877,1371106800"; d="scan'208";a="375964526" Date: Tue, 10 Sep 2013 12:42:24 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Intel Graphics Development , LKML Subject: Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Fully translate sync flags in the dtd->mode conversion Message-ID: <20130910094224.GK11428@intel.com> References: <522A5008.6060005@t-online.de> <1378800168-32277-1-git-send-email-daniel.vetter@ffwll.ch> <20130910093824.GJ11428@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130910093824.GJ11428@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2339 Lines: 61 On Tue, Sep 10, 2013 at 12:38:24PM +0300, Ville Syrj?l? wrote: > On Tue, Sep 10, 2013 at 10:02:48AM +0200, Daniel Vetter wrote: > > Instead of just a flag bit for each of the positive/negative sync > > modes drm actually uses a separate flag for each ... This upsets the > > modeset checker since the adjusted mode filled out at modeset time > > doesn't match the one reconstructed at check time (since the > > ->get_config callback already gets this right). > > > > Reported-by: Knut Petersen > > Cc: Knut Petersen > > References: http://www.gossamer-threads.com/lists/linux/kernel/1778688?do=post_view_threaded > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/i915/intel_sdvo.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > > index 85037b9..5033c74 100644 > > --- a/drivers/gpu/drm/i915/intel_sdvo.c > > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > > @@ -866,8 +866,12 @@ static void intel_sdvo_get_mode_from_dtd(struct drm_display_mode * mode, > > mode->flags |= DRM_MODE_FLAG_INTERLACE; > > if (dtd->part2.dtd_flags & DTD_FLAG_HSYNC_POSITIVE) > > mode->flags |= DRM_MODE_FLAG_PHSYNC; > > + else > > + mode->flags |= DRM_MODE_FLAG_NHSYNC; > > if (dtd->part2.dtd_flags & DTD_FLAG_VSYNC_POSITIVE) > > mode->flags |= DRM_MODE_FLAG_PVSYNC; > > + else > > + mode->flags |= DRM_MODE_FLAG_NVSYNC; > > Actually it seems we don't recreate the mode from scratch here, so we > should also clear the negative sync flags (and the interlace flag too) > before we set them. ... and we seem to be missing a drm_mode_set_crtcinfo() call too. > > > } > > > > static bool intel_sdvo_check_supp_encode(struct intel_sdvo *intel_sdvo) > > -- > > 1.8.4.rc3 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrj?l? > Intel OTC -- Ville Syrj?l? Intel OTC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/