Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001Ab3IJT13 (ORCPT ); Tue, 10 Sep 2013 15:27:29 -0400 Received: from mail-vb0-f43.google.com ([209.85.212.43]:57552 "EHLO mail-vb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952Ab3IJT11 (ORCPT ); Tue, 10 Sep 2013 15:27:27 -0400 MIME-Version: 1.0 In-Reply-To: <20130910191319.GZ13318@ZenIV.linux.org.uk> References: <20130910184324.GY13318@ZenIV.linux.org.uk> <20130910191319.GZ13318@ZenIV.linux.org.uk> Date: Tue, 10 Sep 2013 12:27:27 -0700 X-Google-Sender-Auth: qtbefDBHBi02lM_Vjm0JnM7QCek Message-ID: Subject: Re: kernel BUG at fs/dcache.c:648! with v3.11-7890-ge5c832d From: Linus Torvalds To: Al Viro Cc: Josh Boyer , Waiman Long , "Linux-Kernel@Vger. Kernel. Org" , Mace Moneta Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 29 On Tue, Sep 10, 2013 at 12:13 PM, Al Viro wrote: > > Ugh... I really don't like that - your patch introduces the situations > when race with chroot can lead to two absolute symlinks in the same path > being interpreted wrt different roots. And yes, sure, anybody who gets > in that kind of races isn't going to get particulary sane results, but > still, I'd rather have simpler semantics here... Well, that "root is whatever it happens to be when we encounter the slash" semantics is actually what we used to have before nameidata anyway, so I don't actually believe it's anything new. But I'll commit the simple patch that doesn't clean things up. I guess we can always revisit this later (although I fear that once it all works, we'll just leave it in the ugly state). > Another thing: could you merge vfs.git#for-linus? It's getting really > messy to keep track of changes both in mainline and in vfs.git, especially > since there's a pile of pending stuff (lru_list work) that needs to be > resolved wrt both... Will do. I was hoping to get this sorted out first. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/