Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164Ab3IJVhb (ORCPT ); Tue, 10 Sep 2013 17:37:31 -0400 Received: from a9-92.smtp-out.amazonses.com ([54.240.9.92]:39198 "EHLO a9-92.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088Ab3IJVha (ORCPT ); Tue, 10 Sep 2013 17:37:30 -0400 Date: Tue, 10 Sep 2013 21:37:28 +0000 From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Ingo Molnar cc: Steven Rostedt , Peter Zijlstra , "Paul E. McKenney" , Frederic Weisbecker , Eric Dumazet , linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, sbw@mit.edu Subject: Re: [PATCH] rcu: Is it safe to enter an RCU read-side critical section? In-Reply-To: <20130909161130.GA27188@gmail.com> Message-ID: <0000014109cebf30-d652cc46-6cf8-4bf1-8ca3-8f9a12c1d7e9-000000@email.amazonses.com> References: <20130906174117.GU3966@linux.vnet.ibm.com> <20130906185927.GE2706@somewhere> <20130909105347.GK31370@twins.programming.kicks-ass.net> <20130909132343.GN3966@linux.vnet.ibm.com> <20130909133604.GC31370@twins.programming.kicks-ass.net> <000001410333127c-486c74ec-3209-4c5e-a92f-0c11e00fa141-000000@email.amazonses.com> <20130909150854.GD26785@twins.programming.kicks-ass.net> <0000014103534c88-48ee11a3-a581-4e52-b2df-3a1168047d96-000000@email.amazonses.com> <20130909160024.GA25555@gmail.com> <20130909120328.583a586d@gandalf.local.home> <20130909161130.GA27188@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SES-Outgoing: 2013.09.10-54.240.9.92 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1349 Lines: 28 On Mon, 9 Sep 2013, Ingo Molnar wrote: > I saw those, he posted 'needs testing' patches. He still behaved > passive-aggressively, pretending that it was some difficult task to > perform, as if we were pulling his teeth. I need your review of those. I will rediff as soon as rc1 is out to send something that can be put into -next. Please tell me until then if the approach is ok. I dont think we can do anything in the merge window. > The thing is, we should not be forced to shout at him at all: Christoph's > should be _proactive_ in addressing the shortcomings that were readily > pointed out literally years ago during review in a friendly fashion, > instead of wasting a lot of people's time trying to argue around it... I have fixed all the issues that Steven pointed out in the past about suspicious __this_cpu operations a long time ago. He seemed to want to implement the checks at that point. Not that difficult if one adds new variants of this_cpu operations. Which was an issue initially. The irqsafe_ this_cpu variants were nixed as the time because it was seen to be too complicated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/