Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752344Ab3IJVkC (ORCPT ); Tue, 10 Sep 2013 17:40:02 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:33636 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994Ab3IJVkA (ORCPT ); Tue, 10 Sep 2013 17:40:00 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 10 Sep 2013 14:39:59 -0700 Message-ID: Subject: Re: [GIT PULL] Device tree updates for v3.12 From: Tim Bird To: Linus Torvalds Cc: Grant Likely , Rob Herring , Linux Kernel Mailing List , "devicetree@vger.kernel.org" , anton@samba.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 37 On Tue, Sep 10, 2013 at 1:50 PM, Linus Torvalds wrote: > On Tue, Sep 10, 2013 at 11:40 AM, Tim Bird wrote: >> How much time does it add to boot to feed the device tree into the >> random number pool. >> >> Some of the device trees are expected to get pretty big. If it's over >> a millisecond, IMHO, it should be configurable (but this is not). > > It's detinitely not a very fast operation. ... > So it might even be a better idea to feed the device tree to a hashing > function (eg SHA1 or even just MD5), and then just mix in the hash. At > least most block hash functions do things a word at a time. It does > *not* need to be cryptographically secure, so MD5 would be plenty good > enough - the only point of the hash would be to give a meaningful > number of result bits from the source array. Well, I'm not sure how many bits of randomness this will add anyway. The way we're using device tree, we get the same values every boot, on all instances of the same phone model. So this seems of little value. Anton, Are there presumably some random fields in device tree? Is this being used to pass randomness from the bootloader? Or are you trying to mix in some "randomness" about the hardware configuration? I'm trying to understand the rationale for this. -- Tim Bird Senior Software Engineer, Sony Mobile Architecture Group Chair, CE Workgroup, Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/