MIME-Version: 1.0
In-Reply-To: <CA+8MBb+i+kmnAMi4dTEX9nGwMLRz0EUz0tY0N7YA2btFEtgmQw@mail.gmail.com>
References: <20130718230312.GA22348@www.outflux.net>
	<CA+8MBb+i+kmnAMi4dTEX9nGwMLRz0EUz0tY0N7YA2btFEtgmQw@mail.gmail.com>
Date: Tue, 10 Sep 2013 15:41:24 -0700
Message-ID: <CAGXu5j+-Hpe1hFH4z8dk1E8ASR4NxNYBH5j_PdgmwGAkWgcFEA@mail.gmail.com>
Subject: Re: [PATCH] panic: call panic handlers before kmsg_dump
From: Kees Cook <keescook@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>, Tony Luck <tony.luck@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Vikram Mulukutla <markivx@codeaurora.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Rusty Russell <rusty@rustcorp.com.au>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 977
Lines: 26

On Thu, Jul 18, 2013 at 4:17 PM, Tony Luck <tony.luck@gmail.com> wrote:
> On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook <keescook@chromium.org> wrote:
>> Since the panic handlers may produce additional information (via printk)
>> for the kernel log, it should be reported as part of the panic output
>> saved by kmsg_dump(). Without this re-ordering, nothing that adds
>> information to a panic will show up in pstore's view when kmsg_dump
>> runs, and is therefore not visible to crash reporting tools that examine
>> pstore output.
>
> Good point.
>
> Acked-by: Tony Luck <tony.luck@intel.com>

Can someone pick this patch up? If akpm doesn't want it, it could live
in the pstore tree maybe?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/