Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936Ab3IJWo7 (ORCPT ); Tue, 10 Sep 2013 18:44:59 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:34438 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab3IJWo6 (ORCPT ); Tue, 10 Sep 2013 18:44:58 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130718230312.GA22348@www.outflux.net> Date: Tue, 10 Sep 2013 15:44:57 -0700 X-Google-Sender-Auth: cETYHzv9IZ2fDBzJpATqr_ZX_6w Message-ID: Subject: Re: [PATCH] panic: call panic handlers before kmsg_dump From: Kees Cook To: Andrew Morton , Tony Luck Cc: Linux Kernel Mailing List , Anton Vorontsov , Colin Cross , Stephen Boyd , Vikram Mulukutla , Peter Zijlstra , Rusty Russell Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 29 On Tue, Sep 10, 2013 at 3:41 PM, Kees Cook wrote: > On Thu, Jul 18, 2013 at 4:17 PM, Tony Luck wrote: >> On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook wrote: >>> Since the panic handlers may produce additional information (via printk) >>> for the kernel log, it should be reported as part of the panic output >>> saved by kmsg_dump(). Without this re-ordering, nothing that adds >>> information to a panic will show up in pstore's view when kmsg_dump >>> runs, and is therefore not visible to crash reporting tools that examine >>> pstore output. >> >> Good point. >> >> Acked-by: Tony Luck > > Can someone pick this patch up? If akpm doesn't want it, it could live > in the pstore tree maybe? Ah, sorry, it seems like it is already in -mm. Never mind! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/