Message-ID: <1378859974.15187.5.camel@joe-AO722>
Subject: Re: Resend: [PATCH 2/2] s390: provide hardware randomness from
 zcrypt card to /dev/random
From: Joe Perches <joe@perches.com>
To: Torsten Duwe <duwe@lst.de>
Cc: tytso@mit.edu, ingo.tuchscherer@de.ibm.com, linux-kernel@vger.kernel.org,
        Hans-Georg Markgraf <MGRF@de.ibm.com>,
        Gerald Schaefer <GERALDSC@de.ibm.com>,
        Martin Schwidefsky <martin.schwidefsky@de.ibm.com>
Date: Tue, 10 Sep 2013 17:39:34 -0700
In-Reply-To: <alpine.LNX.2.00.1309041044470.3219@linux.site>
References: <alpine.LNX.2.00.1309041044470.3219@linux.site>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 828
Lines: 28

On Wed, 2013-09-04 at 10:48 +0200, Torsten Duwe wrote:
[]
> +++ b/drivers/s390/crypto/zcrypt_api.c

> @@ -1141,6 +1144,36 @@ static struct hwrng zcrypt_rng_dev = {
][
> +static int zcrypt_hwrng_fillfn(void *unused)
> +{
> +       long rc;
> +
> +       while (!kthread_should_stop()) {
> +               rc = zcrypt_rng((char *)zcrypt_rng_buffer);
> +               if (rc == -ENODEV || rc == -EINVAL || rc == -ENOMEM) {
> +                       pr_err("zcrypt_rng unavailable: %ld", rc);

please add terminating newlines

			pr_err("zcrypt_rng unavailable: %ld\n", rc);

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/