Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753673Ab3IKC0W (ORCPT ); Tue, 10 Sep 2013 22:26:22 -0400 Received: from mail-we0-f176.google.com ([74.125.82.176]:63483 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605Ab3IKC0T (ORCPT ); Tue, 10 Sep 2013 22:26:19 -0400 MIME-Version: 1.0 In-Reply-To: <20130911014443.GA20996@infradead.org> References: <1378688580-11935-1-git-send-email-linux@roeck-us.net> <20130909015945.GA4029@kroah.com> <522D3153.5000102@roeck-us.net> <20130909023152.GA5329@kroah.com> <522D32F6.4020705@roeck-us.net> <20130909050147.GA3899@osiris> <20130911014443.GA20996@infradead.org> From: Peng Tao Date: Wed, 11 Sep 2013 10:25:57 +0800 Message-ID: Subject: Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA To: Christoph Hellwig , "Dilger, Andreas" Cc: Heiko Carstens , Guenter Roeck , Greg Kroah-Hartman , Linux Kernel Mailing List , "devel@driverdev.osuosl.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 28 On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig wrote: > On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote: >> The problem is access_process_vm() is not exported since certain >> version of kernel including the latest. According to Christoph in the >> other mail, access_process_vm() is also a core mm function that is not >> supposed to be exported. Then what kind of change shall we make in >> order to keep current functionality? > > You should remove the higher level functionality, kernel modules are > not supposed to look at userspace environment variables. > OK. I've looked at the specific case that Lustre uses access_process_vm() to get the jobid environment variable and package it into the RPC requests to server. However, it turns out that in the latest Lustre server code, the jobid in a request is not used anywhere. So it looks like we can just get rid of it. Andreas, could you please confirm this? Is the jobid an obsolete parameter that can be abandoned? Or is there plan to use it somehow in the future? Thanks, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/