Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891Ab3IKL1L (ORCPT ); Wed, 11 Sep 2013 07:27:11 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:61447 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700Ab3IKL0s (ORCPT ); Wed, 11 Sep 2013 07:26:48 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 11 Sep 2013 07:26:47 -0400 Message-ID: Subject: Re: [PATCH] drm/omap: fix error return code in omap_dmm_probe() From: Rob Clark To: Wei Yongjun Cc: David Airlie , Greg KH , Andy Gross , joe@perches.com, yongjun_wei@trendmicro.com.cn, "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 34 On Wed, Sep 11, 2013 at 7:16 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -ENOMEM in the refill memory alloc error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Thanks Reviewed-by: Rob Clark > --- > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > index 9b794c9..ab546c9 100644 > --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c > @@ -675,6 +675,7 @@ static int omap_dmm_probe(struct platform_device *dev) > &omap_dmm->refill_pa, GFP_KERNEL); > if (!omap_dmm->refill_va) { > dev_err(&dev->dev, "could not allocate refill memory\n"); > + ret = -ENOMEM; > goto fail; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/