Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755472Ab3IKQaF (ORCPT ); Wed, 11 Sep 2013 12:30:05 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44007 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755147Ab3IKQaD (ORCPT ); Wed, 11 Sep 2013 12:30:03 -0400 Date: Wed, 11 Sep 2013 09:29:55 -0700 From: Christoph Hellwig To: Peng Tao Cc: Guenter Roeck , Christoph Hellwig , "Dilger, Andreas" , Heiko Carstens , Greg Kroah-Hartman , Linux Kernel Mailing List , "devel@driverdev.osuosl.org" Subject: Re: [PATCH] staging: Disable lustre file system for MIPS, SH, and XTENSA Message-ID: <20130911162955.GA1103@infradead.org> References: <20130909015945.GA4029@kroah.com> <522D3153.5000102@roeck-us.net> <20130909023152.GA5329@kroah.com> <522D32F6.4020705@roeck-us.net> <20130909050147.GA3899@osiris> <20130911014443.GA20996@infradead.org> <20130911023026.GA6273@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 36 On Wed, Sep 11, 2013 at 10:51:50AM +0800, Peng Tao wrote: > I'm not fighting against removing the piece of code. But if there is a > strong reason to keep the functionality, we need to find a way to > implement it. The convenience of using environment variables is that > job scheduler can set the environment and other existing applications > don't have to change. Are there other means to do the same? ioctl and > upcall both need application change AFAIK. There is no use case for it, the kernel has no business looking at these variables. Given that you think it's not even used I don't even know why we're having this discussion. Talking about nasty code, the whole linux-curproc.c is highly questionable: - cfs_curproc_groups_nr: unused and should be removed - cfs_cap_raise/cfs_cap_lower/cfs_cap_raised: needs to go away, modyules must not change access permissions on behalf of processes - the whole cfs_cap_t handling also needs to go away, passing around capabilities is not a concept the kernel supports for a reason - current_is_32bit: Code should just use is_compat_task directly. I've just taken the time to walk through this one file, but it seems like most of libcfs is just as bad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/