Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555Ab3ILHDf (ORCPT ); Thu, 12 Sep 2013 03:03:35 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:41323 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475Ab3ILHDe convert rfc822-to-8bit (ORCPT ); Thu, 12 Sep 2013 03:03:34 -0400 Message-Id: <5231836102000078000F29AD@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.2 Date: Thu, 12 Sep 2013 08:03:29 +0100 From: "Jan Beulich" To: "Kees Cook" , "Joe Perches" Cc: "David Miller" , "Eldad Zack" , "George Spelvin" , "Randy Dunlap" , "Andrew Morton" , "Dan Carpenter" , "Jiri Kosina" , "LKML" Subject: Re: [PATCH] vsprintf: drop comment claiming %n is ignored References: <20130911193040.GA16688@www.outflux.net> <1378929961.4714.21.camel@joe-AO722> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 24 >>> On 11.09.13 at 22:18, Kees Cook wrote: > On Wed, Sep 11, 2013 at 1:06 PM, Joe Perches wrote: >> On Wed, 2013-09-11 at 12:30 -0700, Kees Cook wrote: >>> The %n format is not ignored, so remove the incorrect comment about it. >> >> I think it may be better to reimplement the ignoring. > > Yeah, just had a quick look, and scanf doesn't use this code at all. > I'd much rather remove %n again instead. Why would you want to artificially make the function diverge from the spec? People shouldn't be caught by surprises if at all possible, and one can certainly not expect people to go look at the comment before the function implementation to find out what basic (standard) features _do not_ work (one can expect so when trying to find out about _extensions_). Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/