Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754162Ab3ILLLe (ORCPT ); Thu, 12 Sep 2013 07:11:34 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44059 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943Ab3ILLLc (ORCPT ); Thu, 12 Sep 2013 07:11:32 -0400 Date: Thu, 12 Sep 2013 14:07:53 +0300 From: Dan Carpenter To: KY Srinivasan Cc: Wei Yongjun , "devel@linuxdriverproject.org" , Haiyang Zhang , "yongjun_wei@trendmicro.com.cn" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Drivers: hv: vmbus: fix error return code in vmbus_connect() Message-ID: <20130912110752.GI25896@mwanda> References: <7463564f181640d2ad9658ce0ef7a7b5@SN2PR03MB061.namprd03.prod.outlook.com> <3e6ec2c583e14f17af1a5d2bd6aaab82@SN2PR03MB061.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e6ec2c583e14f17af1a5d2bd6aaab82@SN2PR03MB061.namprd03.prod.outlook.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 21 On Thu, Sep 12, 2013 at 12:36:46AM +0000, KY Srinivasan wrote: > When you try a given version, vmbus_negotiate_version() returns an error code > if the host does not support that version. Hence, in this code you will not be able to > run on anything prior to ws2012. I have already sent in a patch to fix that - if we timeout > only then we jump to cleanup. In any event, if we tried all versions and none was acceptable > to the host, we would return the value from vmbus_negotiate_version(). > First of all Wei's patch fixes an obvious bug. Read the code. If you already fixed it then what's the URL or the subject of your email so we can look for it in our inbox. Give us a clue here. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/