MIME-Version: 1.0
In-Reply-To: <1378805550-29949-42-git-send-email-mgorman@suse.de>
References: <1378805550-29949-1-git-send-email-mgorman@suse.de>
	<1378805550-29949-42-git-send-email-mgorman@suse.de>
Date: Thu, 12 Sep 2013 20:42:18 +0800
Message-ID: <CAJd=RBBOHXT=7NGAkLtcOCMna5g2GvaQG-Xc0mzrbp_mOQ4xyw@mail.gmail.com>
Subject: Re: [PATCH 41/50] sched: numa: Use {cpu, pid} to create task groups
 for shared faults
From: Hillf Danton <dhillf@gmail.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Rik van Riel <riel@redhat.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>, Andrea Arcangeli <aarcange@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>, Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 958
Lines: 31

Hello Mel

On Tue, Sep 10, 2013 at 5:32 PM, Mel Gorman <mgorman@suse.de> wrote:
>
> +void task_numa_free(struct task_struct *p)
> +{
> +       struct numa_group *grp = p->numa_group;
> +       int i;
> +
> +       kfree(p->numa_faults);
> +
> +       if (grp) {
> +               for (i = 0; i < 2*nr_node_ids; i++)
> +                       atomic_long_sub(p->numa_faults[i], &grp->faults[i]);
> +
use after free, numa_faults ;/

> +               spin_lock(&grp->lock);
> +               list_del(&p->numa_entry);
> +               grp->nr_tasks--;
> +               spin_unlock(&grp->lock);
> +               rcu_assign_pointer(p->numa_group, NULL);
> +               put_numa_group(grp);
> +       }
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/