Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753023Ab3ILObF (ORCPT ); Thu, 12 Sep 2013 10:31:05 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:47060 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256Ab3ILObC (ORCPT ); Thu, 12 Sep 2013 10:31:02 -0400 MIME-Version: 1.0 In-Reply-To: <20130912131655.GA8619@hmsreliant.think-freely.org> References: <1378496168-3684-1-git-send-email-nhorman@tuxdriver.com> <20130911141943.GA3181@neilslaptop.think-freely.org> <20130912131655.GA8619@hmsreliant.think-freely.org> Date: Thu, 12 Sep 2013 22:30:59 +0800 Message-ID: Subject: Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure From: Ming Lei To: Neil Horman Cc: Linux Kernel Mailing List , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 21 On Thu, Sep 12, 2013 at 9:16 PM, Neil Horman wrote: >> > Please re-read the patch, then point out to me which printk the above action > will trigger, because its not happening in my testing. If you'll take a look at > fw_get_filesystem_firmware, you'll see that if the filp_open on a firmware file > fails, we continue the for loop through the list of available search paths. No > error is generated in the case you describe above. You are right, sorry for missing "if (IS_ERR(file)) continue;", and looks the patch is good. Acked-by: Ming Lei Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/