Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961Ab3ILPDB (ORCPT ); Thu, 12 Sep 2013 11:03:01 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:48289 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab3ILPDA (ORCPT ); Thu, 12 Sep 2013 11:03:00 -0400 Date: Thu, 12 Sep 2013 11:02:47 -0400 From: Neil Horman To: Ming Lei Cc: Linux Kernel Mailing List , Greg Kroah-Hartman Subject: Re: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure Message-ID: <20130912150247.GB8619@hmsreliant.think-freely.org> References: <1378496168-3684-1-git-send-email-nhorman@tuxdriver.com> <20130911141943.GA3181@neilslaptop.think-freely.org> <20130912131655.GA8619@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 26 On Thu, Sep 12, 2013 at 10:30:59PM +0800, Ming Lei wrote: > On Thu, Sep 12, 2013 at 9:16 PM, Neil Horman wrote: > >> > > Please re-read the patch, then point out to me which printk the above action > > will trigger, because its not happening in my testing. If you'll take a look at > > fw_get_filesystem_firmware, you'll see that if the filp_open on a firmware file > > fails, we continue the for loop through the list of available search paths. No > > error is generated in the case you describe above. > > You are right, sorry for missing "if (IS_ERR(file)) continue;", and looks the > patch is good. > > Acked-by: Ming Lei > > Thanks, Awesome, thanks! Neil > -- > Ming Lei > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/