Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023Ab3ILQkR (ORCPT ); Thu, 12 Sep 2013 12:40:17 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:39150 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754963Ab3ILQkM convert rfc822-to-8bit (ORCPT ); Thu, 12 Sep 2013 12:40:12 -0400 MIME-Version: 1.0 In-Reply-To: <83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce.1376600922.git.yann.morin.1998@free.fr> References: <83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce.1376600922.git.yann.morin.1998@free.fr> Date: Thu, 12 Sep 2013 18:40:12 +0200 Message-ID: Subject: Re: [PATCH 2/4] scripts/config: use sed's POSIX interface From: Linus Walleij To: "Yann E. MORIN" Cc: linux-kbuild@vger.kernel.org, Michal Marek , "linux-kernel@vger.kernel.org" , Clement Chauplannaz Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 46 On Thu, Aug 15, 2013 at 11:17 PM, Yann E. MORIN wrote: > From: Clement Chauplannaz > > Script `config' relies on extensions of `GNU sed', and is thus not > working on all Unixes: > - in-place edition of files (-i), which can be replaced with > a temporary file; > - extended-regexps (-r), which can be split into basic regexps; > - single-line calls to `a' command, while some implementations > require a leading newline before the parameter. > > Rewrite calls to `sed' to comply with POSIX interface, and move them > to helper functions. > > Signed-off-by: Clement Chauplannaz > Tested-by: "Yann E. MORIN" > Reviewed-by: "Yann E. MORIN" > Signed-off-by: Yann E. MORIN This patch totally breaks my usage of the --set-str argument to "config". Reverting this patch solves the problem. Reproduce: make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- KBUILD_OUTPUT=build-nomadik nhk8815_defconfig scripts/config --file build-nomadik/.config --set-str CMDLINE "root=/dev/ram0 console=ttyAMA1,115200n8 earlyprintk" sed: -e uttryck #1, tecken 44: flaggan ok?nd f?r "s" sed: -e uttryck #1, tecken 54: flaggan ok?nd f?r "s" Swedish messages meaning "unknown flag for "s"" After reverting the patch these messages no longer appear. At failure my config file is scratched :-O Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/