Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755590Ab3ILTYe (ORCPT ); Thu, 12 Sep 2013 15:24:34 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:39985 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519Ab3ILTYd (ORCPT ); Thu, 12 Sep 2013 15:24:33 -0400 Message-ID: <1379013759.13477.12.camel@misato.fc.hp.com> Subject: Re: [RESEND PATCH v2 3/9] x86, dma: Support allocate memory from bottom upwards in dma_contiguous_reserve(). From: Toshi Kani To: Tang Chen Cc: tj@kernel.org, rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org Date: Thu, 12 Sep 2013 13:22:39 -0600 In-Reply-To: <1378979537-21196-4-git-send-email-tangchen@cn.fujitsu.com> References: <1378979537-21196-1-git-send-email-tangchen@cn.fujitsu.com> <1378979537-21196-4-git-send-email-tangchen@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1951 Lines: 67 On Thu, 2013-09-12 at 17:52 +0800, Tang Chen wrote: > During early boot, if the bottom up mode is set, just > try allocating bottom up from the end of kernel image, > and if that fails, do normal top down allocation. > > So in function dma_contiguous_reserve(), we add the > above logic. > > Signed-off-by: Tang Chen > Reviewed-by: Zhang Yanfei > --- > drivers/base/dma-contiguous.c | 17 ++++++++++++++--- > 1 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c > index 99802d6..aada945 100644 > --- a/drivers/base/dma-contiguous.c > +++ b/drivers/base/dma-contiguous.c > @@ -228,17 +228,28 @@ int __init dma_contiguous_reserve_area(phys_addr_t size, phys_addr_t base, > goto err; > } > } else { > + phys_addr_t addr; > + > + if (memblock_direction_bottom_up()) { > + addr = memblock_alloc_bottom_up( > + MEMBLOCK_ALLOC_ACCESSIBLE, > + limit, size, alignment); > + if (addr) > + goto success; > + } I am afraid that this version went to a wrong direction. Allocating from the bottom up needs to be an internal logic within the memblock allocator. It should not require the callers to be aware of the direction and make a special request. Thanks, -Toshi > + > /* > * Use __memblock_alloc_base() since > * memblock_alloc_base() panic()s. > */ > - phys_addr_t addr = __memblock_alloc_base(size, alignment, limit); > + addr = __memblock_alloc_base(size, alignment, limit); > if (!addr) { > ret = -ENOMEM; > goto err; > - } else { > - base = addr; > } > + > +success: > + base = addr; > } > > /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/