Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756539Ab3ILURc (ORCPT ); Thu, 12 Sep 2013 16:17:32 -0400 Received: from mx11.netapp.com ([216.240.18.76]:39787 "EHLO mx11.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803Ab3ILURa (ORCPT ); Thu, 12 Sep 2013 16:17:30 -0400 X-IronPort-AV: E=Sophos;i="4.90,892,1371106800"; d="scan'208";a="49291458" From: "Myklebust, Trond" To: Geert Uytterhoeven CC: Linux/m68k , "linux-kernel@vger.kernel.org" Subject: Re: Kernel size increase of +256 KiB (was: Re: RPCSEC_GSS: Share all credential caches on a per-transport basis) Thread-Topic: Kernel size increase of +256 KiB (was: Re: RPCSEC_GSS: Share all credential caches on a per-transport basis) Thread-Index: AQHOr7tznpOxKw98ykmpioj1Q9on0JnCmnmAgABVoICAAA/1AA== Date: Thu, 12 Sep 2013 20:17:23 +0000 Message-ID: <1379017042.2627.3.camel@leira.trondhjem.org> References: <1378995227.3117.9.camel@leira.trondhjem.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.106.53.51] Content-Type: text/plain; charset="utf-8" Content-ID: <62C5D6F1628FEB4F8A05EE2F9C092075@hq.netapp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r8CKHZMV016232 Content-Length: 2330 Lines: 68 On Thu, 2013-09-12 at 21:20 +0200, Geert Uytterhoeven wrote: > On Thu, Sep 12, 2013 at 4:13 PM, Myklebust, Trond > wrote: > >> > --- a/net/sunrpc/auth_gss/auth_gss.c > >> > +++ b/net/sunrpc/auth_gss/auth_gss.c > >> > @@ -51,6 +51,7 @@ > >> > #include > >> > #include > >> > #include > >> > +#include > >> > > >> > #include "../netns.h" > >> > > >> > @@ -71,6 +72,9 @@ static unsigned int gss_expired_cred_retry_delay = GSS_RETRY_EXPIRED; > >> > * using integrity (two 4-byte integers): */ > >> > #define GSS_VERF_SLACK 100 > >> > > >> > +static DEFINE_HASHTABLE(gss_auth_hash_table, 16); > >> > +static DEFINE_SPINLOCK(gss_auth_hash_lock); > >> > >> Today's m68k/atari-defconfig kernel no longer boots, as it became larger than > >> 4 MiB. > >> > >> bloat-o-meter tells me: > >> > >> function old new delta > >> gss_auth_hash_table - 262144 +262144 > >> > >> Woops... > > > > Whoops indeed. The above should have declared 16 buckets, and not 1<<16. > > I fell for Sasha's subtle trap... > > > >> Are you trying to game Tim's survey? ;-) > >> (question 13 at http://www.embeddedlinuxconference.com/cgi-bin/survey.cgi) > >> > >> Can this memory be allocated dynamically / only when it's used? > > > > :-) It's declared inside a module, so that should already be the case, > > Only for the modular case. What about builtin, e.g. for nfsroot? > > Or is it better to not build in NFS_V4 support in that case? > > config NFS_V4 > If unsure, say Y. > > config NFSD_V4 > If unsure, say N. > > So that's why my defconfig has NFS_V4 but not NFSD_V4. It should be possible now to compile in NFSv3 support (and/or NFSv2), while keeping NFSv4 a module. That will usually result in CONFIG_SUNRPC_GSS=m... Of course, if your defconfig doesn't have module support then, yes, your only option to avoid compiling in rpcsec_gss is to not select NFSv4 at all. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?