Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757383Ab3IMA5f (ORCPT ); Thu, 12 Sep 2013 20:57:35 -0400 Received: from mail-we0-f170.google.com ([74.125.82.170]:56468 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754495Ab3IMA5e convert rfc822-to-8bit (ORCPT ); Thu, 12 Sep 2013 20:57:34 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:6e3b:e5ff:fe16:f1aa] In-Reply-To: <1379032225-6425-1-git-send-email-emilio@elopez.com.ar> References: <1378863781-4235-1-git-send-email-emilio@elopez.com.ar> <1379032225-6425-1-git-send-email-emilio@elopez.com.ar> Date: Thu, 12 Sep 2013 17:57:32 -0700 Message-ID: Subject: Re: [PATCH] memory: add a basic OF-based memory driver From: Olof Johansson To: =?ISO-8859-1?Q?Emilio_L=F3pez?= Cc: Mike Turquette , Maxime Ripard , Grant Likely , Rob Herring , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , =?ISO-8859-1?Q?David_Lanzend=F6rfer?= , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 25 On Thu, Sep 12, 2013 at 5:30 PM, Emilio L?pez wrote: > This driver's only job is to claim and ensure the necessary clock > for memory operation on a DT-powered machine remains enabled. > > Signed-off-by: Emilio L?pez > --- > > I believe this new patch should resolve all the concerns raised; as > always, all feedback is welcome :) I think you're going about this the wrong way. If you have a problem with a clock not staying on, shouldn't you just marking it appropriately in the clock table instead, making sure it's initialized with at least one reference to it? I believe that is how some of the other platforms handle this, and it's a lot cleaner than adding a fake binding and a fake driver just to grab a single clock. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/