Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757488Ab3IMCIl (ORCPT ); Thu, 12 Sep 2013 22:08:41 -0400 Received: from mail-oa0-f41.google.com ([209.85.219.41]:37917 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757314Ab3IMCIh (ORCPT ); Thu, 12 Sep 2013 22:08:37 -0400 MIME-Version: 1.0 In-Reply-To: <87ioy536mu.fsf@rustcorp.com.au> References: <1378955676-12708-1-git-send-email-peter.chen@freescale.com> <87ioy536mu.fsf@rustcorp.com.au> From: Lucas De Marchi Date: Thu, 12 Sep 2013 23:08:15 -0300 Message-ID: Subject: Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async To: Rusty Russell Cc: Peter Chen , lkml Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 23 On Thu, Sep 12, 2013 at 9:30 PM, Rusty Russell wrote: > Peter Chen writes: >> Currently, if module's refcount is not zero during the unload, >> it waits there until the user decreases that refcount. > > Hi Peter, > > In practice userspace uses O_NONBLOCK. In fact, I've been > thinking of removing the blocking case altogether, since it's not really > what people want. > > That would solve your problem and make the code simpler. Thoughts? I'm all in favor of this. It's been almost 1 year it's deprecated in kmod and if anyone tries to use we force a 10s delay on module removal. So far nobody complained. Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/