Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756563Ab3IMIis (ORCPT ); Fri, 13 Sep 2013 04:38:48 -0400 Received: from mail-vc0-f171.google.com ([209.85.220.171]:62149 "EHLO mail-vc0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755753Ab3IMIio convert rfc822-to-8bit (ORCPT ); Fri, 13 Sep 2013 04:38:44 -0400 MIME-Version: 1.0 In-Reply-To: References: <83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce.1376600922.git.yann.morin.1998@free.fr> Date: Fri, 13 Sep 2013 10:38:43 +0200 Message-ID: Subject: Re: [PATCH 2/4] scripts/config: use sed's POSIX interface From: =?ISO-8859-1?Q?Cl=E9ment_Chauplannaz?= To: Linus Walleij Cc: "Yann E. MORIN" , linux-kbuild@vger.kernel.org, Michal Marek , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2206 Lines: 61 2013/9/12 Linus Walleij : > On Thu, Aug 15, 2013 at 11:17 PM, Yann E. MORIN wrote: > >> From: Clement Chauplannaz >> >> Script `config' relies on extensions of `GNU sed', and is thus not >> working on all Unixes: >> - in-place edition of files (-i), which can be replaced with >> a temporary file; >> - extended-regexps (-r), which can be split into basic regexps; >> - single-line calls to `a' command, while some implementations >> require a leading newline before the parameter. >> >> Rewrite calls to `sed' to comply with POSIX interface, and move them >> to helper functions. >> >> Signed-off-by: Clement Chauplannaz >> Tested-by: "Yann E. MORIN" >> Reviewed-by: "Yann E. MORIN" >> Signed-off-by: Yann E. MORIN > > This patch totally breaks my usage of the --set-str > argument to "config". > > Reverting this patch solves the problem. > > Reproduce: > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- > KBUILD_OUTPUT=build-nomadik nhk8815_defconfig > scripts/config --file build-nomadik/.config --set-str CMDLINE > "root=/dev/ram0 console=ttyAMA1,115200n8 earlyprintk" > sed: -e uttryck #1, tecken 44: flaggan ok?nd f?r "s" > sed: -e uttryck #1, tecken 54: flaggan ok?nd f?r "s" > > Swedish messages meaning "unknown flag for "s"" > > After reverting the patch these messages no longer appear. > > At failure my config file is scratched :-O > > Yours, > Linus Walleij Hello Linus, Thank you for this report. I was able to reproduce this bug and fix it. My previous commit changed the separator between sed's substitute command and its parameters, from ':' to '/'. The latter conflicted with the slashes found in the value of variable CMDLINE, as provided in your email. I'm sending a patch right now to revert to previous behavior. Best regards, Clement Chauplannaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/