Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755912Ab3IMJyp (ORCPT ); Fri, 13 Sep 2013 05:54:45 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:60220 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718Ab3IMJyh convert rfc822-to-8bit (ORCPT ); Fri, 13 Sep 2013 05:54:37 -0400 References: <83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce.1376600922.git.yann.morin.1998@free.fr> Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Message-Id: Cc: "Yann E. MORIN" , linux-kbuild , Michal Marek , "linux-kernel@vger.kernel.org" X-Mailer: iPhone Mail (10B350) From: =?utf-8?Q?Cl=C3=A9ment_Chauplannaz?= Subject: Re: [PATCH 2/4] scripts/config: use sed's POSIX interface Date: Fri, 13 Sep 2013 11:54:31 +0200 To: Linus Walleij Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 26 On Sep 13, 2013, at 11:32 AM, Linus Walleij wrote: > On Fri, Sep 13, 2013 at 10:38 AM, Clément Chauplannaz > wrote: > >> Thank you for this report. I was able to reproduce this bug and fix it. > > Thanks! Tested and works fine. Glad to read the patch solves your issue. Thanks for the quick feedback! > >> My previous commit changed the separator between sed's substitute >> command and its parameters, from ':' to '/'. The latter conflicted >> with the slashes found in the value of variable CMDLINE, as provided >> in your email. > > Hm it could actually be useful to be able to have colons in a CMDLINE, > I wonder if we can think about some better separator ... oh well that > is another issue, all old scripts work now anyway. Indeed config script may not work with all possible string values. My first concern for now was to fallback to previous interface. We may look into hardening the script later on. Best regards, Clement Chauplannaz-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/