Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757018Ab3IMP0y (ORCPT ); Fri, 13 Sep 2013 11:26:54 -0400 Received: from ra.se.axis.com ([195.60.68.13]:49600 "EHLO ra.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756010Ab3IMP0v (ORCPT ); Fri, 13 Sep 2013 11:26:51 -0400 Date: Fri, 13 Sep 2013 17:26:49 +0200 From: Jesper Nilsson To: Viresh Kumar Cc: "rjw@sisk.pl" , "linaro-kernel@lists.linaro.org" , "patches@linaro.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jesper Nilsson , Mikael Starvik , linux-cris-kernel Subject: Re: [PATCH 187/228] cpufreq: cris: remove calls to cpufreq_notify_transition() Message-ID: <20130913152649.GI32443@axis.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 35 On Fri, Sep 13, 2013 at 03:02:13PM +0200, Viresh Kumar wrote: > Most of the drivers do following in their ->target_index() routines: > > struct cpufreq_freqs freqs; > freqs.old = old freq... > freqs.new = new freq... > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); > > /* Change rate here */ > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); > > This is replicated over all cpufreq drivers today and there doesn't exists a > good enough reason why this shouldn't be moved to cpufreq core instead. > > Earlier patches have added support in cpufreq core to do cpufreq notification on > frequency change, this one removes it from this driver. > > Some related minor cleanups are also done along with it. Acked-by: Jesper Nilsson > Cc: Mikael Starvik > Cc: linux-cris-kernel@axis.com > Signed-off-by: Viresh Kumar /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/