Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757529Ab3IMPya (ORCPT ); Fri, 13 Sep 2013 11:54:30 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:54643 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757485Ab3IMPy2 (ORCPT ); Fri, 13 Sep 2013 11:54:28 -0400 Date: Fri, 13 Sep 2013 16:53:13 +0100 From: Russell King - ARM Linux To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, patches@linaro.org, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 181/228] cpufreq: move freq change notifications to cpufreq core Message-ID: <20130913155313.GA12758@n2100.arm.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 607 Lines: 12 On Fri, Sep 13, 2013 at 06:32:07PM +0530, Viresh Kumar wrote: > + read_lock_irqsave(&cpufreq_driver_lock, flags); > + notify = !(cpufreq_driver->flags & CPUFREQ_ASYNC_NOTIFICATION); > + read_unlock_irqrestore(&cpufreq_driver_lock, flags); I don't think this needs to be read under a lock - if this bit changes dynamically, then there's something very wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/