Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754312Ab3IMQWe (ORCPT ); Fri, 13 Sep 2013 12:22:34 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:56448 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752828Ab3IMQWb (ORCPT ); Fri, 13 Sep 2013 12:22:31 -0400 MIME-Version: 1.0 In-Reply-To: <20130913161527.GE12758@n2100.arm.linux.org.uk> References: <6e2ca86ce948c0bc35f7709baf22672771fcf1e8.1379063063.git.viresh.kumar@linaro.org> <20130913155424.GB12758@n2100.arm.linux.org.uk> <20130913161527.GE12758@n2100.arm.linux.org.uk> Date: Fri, 13 Sep 2013 21:52:31 +0530 Message-ID: Subject: Re: [PATCH 206/228] cpufreq: sa11x0: remove calls to cpufreq_notify_transition() From: Viresh Kumar To: Russell King - ARM Linux Cc: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 26 On 13 September 2013 21:45, Russell King - ARM Linux wrote: > The patch to which I'm replying removes the above calls. These calls are > necessary to shutdown various bits of CPU-clock dependent hardware > before changing the CPU clock, and restore them - reconfiguring them > for the new clock rate after the transition has happened. > > So, if you're removing these calls, what replaces them? I don't see > anything which does without the above set. The other patch on which you commented about unnecessary read locks being taken: [PATCH 181/228] cpufreq: move freq change notifications to cpufreq That calls these notifiers, for all platforms except the ones that have set CPUFREQ_ASYNC_NOTIFICATION, before and after calling ->target_index().. And so functionally the code is supposed to be the same.. Unless I have done some stupid mistake.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/