Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441Ab3IMQYD (ORCPT ); Fri, 13 Sep 2013 12:24:03 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:60250 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751883Ab3IMQX7 (ORCPT ); Fri, 13 Sep 2013 12:23:59 -0400 Date: Fri, 13 Sep 2013 18:23:56 +0200 From: Johan Hovold To: Paul Chavent Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, jhovold@gmail.com, fschaefer.oss@googlemail.com, jslaby@suse.cz, max@suse.de, giometti@enneenne.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] USB : serial : pl2303 wake up after dcd status check. Message-ID: <20130913162356.GC9054@localhost> References: <1379086513-2434-1-git-send-email-paul.chavent@onera.fr> <1379086513-2434-4-git-send-email-paul.chavent@onera.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379086513-2434-4-git-send-email-paul.chavent@onera.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 54 On Fri, Sep 13, 2013 at 05:35:13PM +0200, Paul Chavent wrote: > Seems to be done this way in other drivers (ch341, 8250, ...). > And get tty reference only if dcd_change need to be called. This is fine. I have a patch here doing the same two changes as part of a larger clean-up of the pl2303 interrupt handling (which in turn is part of the MSR-refactoring I mentioned). I could rebase on top of this, unless you care to wait another week. :) Thanks, Johan > Signed-off-by: Paul Chavent > --- > drivers/usb/serial/pl2303.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c > index e7a84f0..8b81188 100644 > --- a/drivers/usb/serial/pl2303.c > +++ b/drivers/usb/serial/pl2303.c > @@ -854,15 +854,16 @@ static void pl2303_update_line_status(struct usb_serial_port *port, > spin_unlock_irqrestore(&priv->lock, flags); > if (priv->line_status & UART_BREAK_ERROR) > usb_serial_handle_break(port); > - wake_up_interruptible(&port->port.delta_msr_wait); > > - tty = tty_port_tty_get(&port->port); > - if (!tty) > - return; > - if ((priv->line_status ^ prev_line_status) & UART_DCD) > - usb_serial_handle_dcd_change(port, tty, > - priv->line_status & UART_DCD); > - tty_kref_put(tty); > + if ((priv->line_status ^ prev_line_status) & UART_DCD) { > + tty = tty_port_tty_get(&port->port); > + if (tty) > + usb_serial_handle_dcd_change(port, tty, > + priv->line_status & UART_DCD); > + tty_kref_put(tty); > + } > + > + wake_up_interruptible(&port->port.delta_msr_wait); > } > > static void pl2303_read_int_callback(struct urb *urb) > -- > 1.7.12.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/