Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754345Ab3IMQYB (ORCPT ); Fri, 13 Sep 2013 12:24:01 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:55805 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753268Ab3IMQX7 (ORCPT ); Fri, 13 Sep 2013 12:23:59 -0400 MIME-Version: 1.0 In-Reply-To: <20130913161820.GM19363@lunn.ch> References: <0a512914fd48b2d6db685446f88b9a096eff79a1.1379063063.git.viresh.kumar@linaro.org> <20130913161820.GM19363@lunn.ch> Date: Fri, 13 Sep 2013 21:53:58 +0530 Message-ID: Subject: Re: [PATCH 195/228] cpufreq: kirkwood: remove calls to cpufreq_notify_transition() From: Viresh Kumar To: Andrew Lunn Cc: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 32 On 13 September 2013 21:48, Andrew Lunn wrote: > On Fri, Sep 13, 2013 at 06:32:21PM +0530, Viresh Kumar wrote: > >> - if (freqs.old != freqs.new) { >> - local_irq_disable(); >> - >> - /* Disable interrupts to the CPU */ >> - reg = readl_relaxed(priv.base); >> - reg |= CPU_SW_INT_BLK; >> - writel_relaxed(reg, priv.base); >> - >> - switch (state) { >> - case STATE_CPU_FREQ: >> - clk_disable(priv.powersave_clk); >> - break; >> - case STATE_DDR_FREQ: >> - clk_enable(priv.powersave_clk); >> - break; >> - } > > Hi Viresh > > I see you removed the test that the old and the new frequency are > different. Is this guaranteed by the core? Because if not, you can > lockup the CPU. The call to cpu_do_idle() will never return. Yes, that's guaranteed by core: patch 181.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/