Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648Ab3IMR6G (ORCPT ); Fri, 13 Sep 2013 13:58:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38285 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529Ab3IMR6E (ORCPT ); Fri, 13 Sep 2013 13:58:04 -0400 Date: Fri, 13 Sep 2013 10:58:01 -0700 From: Mark Fasheh To: Chris Mason Cc: Guenter Roeck , Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , linux-btrfs , Zach Brown Subject: Re: Build failures due to commit 416161db (btrfs: offline dedupe) Message-ID: <20130913175801.GL31381@wotan.suse.de> Reply-To: Mark Fasheh References: <20130913133314.GA20461@roeck-us.net> <20130913163535.GA5681@roeck-us.net> <20130913170022.18785.82013@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130913170022.18785.82013@localhost.localdomain> Organization: SUSE Labs User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1998 Lines: 45 On Fri, Sep 13, 2013 at 01:00:22PM -0400, Chris Mason wrote: > Quoting Guenter Roeck (2013-09-13 12:35:35) > > On Fri, Sep 13, 2013 at 03:52:43PM +0200, Geert Uytterhoeven wrote: > > > On Fri, Sep 13, 2013 at 3:33 PM, Guenter Roeck wrote: > > > > fs/btrfs/ioctl.c: In function 'btrfs_ioctl_file_extent_same': > > > > fs/btrfs/ioctl.c:2802:3: error: implicit declaration of function '__put_user_unaligned' [-Werror=implicit-function-declaration] > > > > cc1: some warnings being treated as errors > > > > make[2]: *** [fs/btrfs/ioctl.o] Error 1 > > > > make[2]: *** Waiting for unfinished jobs.... > > > > > > > > Seen with alpha:allmodconfig, arm:allmodconfig, m68k:allmodconfig, and > > > > xtensa:allmodconfig. > > > > > > Known issue, cfr. my early warning 10 days ago: > > > > > > "Btrfs is the first user of __put_user_unaligned() outside the compat code, > > > hence now all 32-bit architectures should make sure to implement this, too." > > > > > > http://marc.info/?l=linux-arch&m=137820065929216&w=2 > > > > > > and today's thread https://lkml.org/lkml/2013/9/12/814 > > > > > > > It doesn't seem right that a patch breaks the build for several platforms, and > > the problem is then blamed on the platform code instead of the code that is > > introducing the problem. > > > > Maybe we should add BROKEN to the btrfs dependencies for the affected platforms. > > After all, it _is_ broken. > > I'm happy to fix this with a bigger put of the info struct, just > let me know the preferred arch-happy solution. In fact old versions of the patch were putting the whole struct but during review I was asked to change it. This should be very straight forward to fix so long as we all stay calm ;) --Mark -- Mark Fasheh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/