Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754981Ab3IMUSH (ORCPT ); Fri, 13 Sep 2013 16:18:07 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:45219 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754338Ab3IMUSG (ORCPT ); Fri, 13 Sep 2013 16:18:06 -0400 Date: Fri, 13 Sep 2013 21:18:03 +0100 From: Al Viro To: Linus Torvalds Cc: Andrew Morton , Stephen Rothwell , linux-next , Linux Kernel Mailing List , Dave Chinner , Glauber Costa Subject: Re: linux-next: manual merge of the akpm tree with Linus' tree Message-ID: <20130913201803.GU13318@ZenIV.linux.org.uk> References: <20130910153520.14e49cd32feb16d45eb8abac@linux-foundation.org> <20130910223624.GC13318@ZenIV.linux.org.uk> <20130910154116.cc4afe048213a779040ea3cc@linux-foundation.org> <20130910224823.GE13318@ZenIV.linux.org.uk> <20130910225934.GF13318@ZenIV.linux.org.uk> <20130913200000.GT13318@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130913200000.GT13318@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 25 On Fri, Sep 13, 2013 at 09:00:00PM +0100, Al Viro wrote: > > - d_lru_shrink_move: move from the "global" lru list to a private shrinker list > > - d_shrink_add/del: fairly obvious. > > > > And then "denty_lru_add/del" that actually take the current state into > > account and do the right thing. Those we had before, I'm just > > explaining the difference from the low-level operations that have > > fixed "from this state to that" semantics > > Looks sane; FWIW, the variant I'm playing with uses two independent > flags for "shrinker" and "per-sb", but AFAICS that doesn't yield better > code. Actually, it does yield slightly better code... Look - if you take your patch and replace LRU_LIST | SHRINK_LIST combination with bare SHRINK_LIST (which can't occur right now). Then all transitions turn into flipping a single bit, check in dentry_lru_add() becomes if (!(flags & (SHRINK | LRU)) and dentry_lru_del() -- if (... & SHRINK) return ...; if (... & LRU) return ... It can be done as a followup, anyway - better not mix that with fixes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/