Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932116Ab3INOVK (ORCPT ); Sat, 14 Sep 2013 10:21:10 -0400 Received: from mail-vc0-f181.google.com ([209.85.220.181]:34562 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756510Ab3INOVI (ORCPT ); Sat, 14 Sep 2013 10:21:08 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Sat, 14 Sep 2013 16:21:05 +0200 Message-ID: Subject: Re: scripts/config: fix variable substitution command From: =?ISO-8859-1?Q?Cl=E9ment_Chauplannaz?= To: sedat.dilek@gmail.com Cc: Michal Marek , linux-kbuild@vger.kernel.org, LKML , Linus Torvalds , Linus Walleij Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2449 Lines: 74 2013/9/14 Sedat Dilek : > Hi, > > The ChangeLog from [1] says: > > Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed > the separator between sed `s' command and its parameters from ':' to > '/'. > Revert this change. > > Reported-and-tested-by: Linus Walleij > Signed-off-by: Clement Chauplannaz > Signed-off-by: Michal Marek > > *** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 *** > (Linus-tree) > > To quote [2] and see its EXAMPLE: > > "If you want to refer to a specific commit, don't just refer to the > SHA-1 ID of the commit. Please also include the oneline summary of > the commit, to make it easier for reviewers to know what it is about. > > Example: > > Commit e21d2170f36602ae2708 ("video: remove unnecessary > platform_set_drvdata()") removed the unnecessary > platform_set_drvdata(), but left the variable "dev" unused, > delete it." > > That's why the commit-id without the subject-line is no good help. > It does not help anyone when you reference a local GIT or linux-kbuild > GIT related commit-id. > > So, can you point me/us to the correct commit with subject, please?! > Is this patch even "CC: stable"? > > Thanks. > > Regards, > - Sedat - > > > [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d > [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112 Hi Sedat, My apologies for that mistake. The initial commit, as present in Linus tree, is: 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's POSIX interface Thus, the commit message for this patch should read: scripts/config: fix variable substitution command Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's POSIX interface") accidentally changed the separator between sed `s' command and its parameters from ':' to '/'. Revert this change. Reported-and-tested-by: Linus Walleij Signed-off-by: Clement Chauplannaz Signed-off-by: Michal Marek Regards, Clement -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/